From 6de7e26f332add9116364ba4ffb3bd9919c79572 Mon Sep 17 00:00:00 2001
From: CodingPhoenixx <codingphoenix@coph.dev>
Date: Mon, 15 Jun 2026 07:24:59 +0200
Subject: [PATCH] Remove redundant code comments for improved readability and
 maintainability

---
 .../nextusweb/server/HttpRequestHandler.java     | 16 ++--------------
 .../dev/coph/nextusweb/server/HttpServer.java    |  4 +---
 .../dev/coph/nextusweb/server/net/ClientIp.java  |  5 +----
 .../nextusweb/server/net/TrustedProxies.java     |  6 ++----
 .../server/ratelimit/RateLimitConfig.java        |  3 ---
 .../server/ratelimit/RateLimitGate.java          |  1 -
 .../dev/coph/nextusweb/server/router/Router.java |  2 --
 .../dev/coph/nextusweb/server/tls/TlsConfig.java |  2 --
 .../server/websocket/WebSocketGroup.java         |  2 --
 9 files changed, 6 insertions(+), 35 deletions(-)

diff --git a/src/main/java/dev/coph/nextusweb/server/HttpRequestHandler.java b/src/main/java/dev/coph/nextusweb/server/HttpRequestHandler.java
index 8c2e93e..e5f74c2 100644
--- a/src/main/java/dev/coph/nextusweb/server/HttpRequestHandler.java
+++ b/src/main/java/dev/coph/nextusweb/server/HttpRequestHandler.java
@@ -155,8 +155,6 @@ public final class HttpRequestHandler extends SimpleChannelInboundHandler<FullHt
             if (handleWebSocketUpgrade(ctx, req)) return;
         }
 
-        // Backpressure: stop pulling further requests off this connection until we have answered
-        // the current one, bounding buffered request memory to one aggregated body per connection.
         ctx.channel().config().setAutoRead(false);
 
         req.retain();
@@ -214,8 +212,7 @@ public final class HttpRequestHandler extends SimpleChannelInboundHandler<FullHt
             return true;
         }
 
-        // Authenticate the upgrade if an auth layer is configured. WebSocket authenticators should
-        // be cheap (cookie/token validation) since the handshake runs on the event loop.
+
         Principal principal = null;
         if (authGate != null) {
             Request upgradeReq = new Request(req, resolution.pathParams());
@@ -239,8 +236,6 @@ public final class HttpRequestHandler extends SimpleChannelInboundHandler<FullHt
         ChannelPipeline pipeline = ctx.pipeline();
         String myName = ctx.name();
 
-        // The plain-HTTP read timeout would close idle WebSocket connections (which legitimately
-        // stay quiet between frames), so drop it; the WebSocket idle handler governs liveness.
         if (pipeline.get("read-timeout") != null) {
             pipeline.remove("read-timeout");
         }
@@ -256,8 +251,7 @@ public final class HttpRequestHandler extends SimpleChannelInboundHandler<FullHt
         }
         pipeline.addBefore(myName, "ws-proto",
                 new WebSocketServerProtocolHandler(protoCfg));
-        // Reassemble fragmented (continuation) frames into a single logical message, bounded by
-        // the configured aggregate size so a stream of fragments cannot amplify memory use.
+
         pipeline.addBefore(myName, "ws-aggregator",
                 new WebSocketFrameAggregator(wsConfig.maxAggregatedMessageSize()));
         pipeline.addBefore(myName, "ws-frames",
@@ -304,8 +298,6 @@ public final class HttpRequestHandler extends SimpleChannelInboundHandler<FullHt
             Request request = new Request(raw, params);
             request.clientIp(clientIp);
 
-            // Rate limiting runs before authentication so an unauthenticated flood is shed before
-            // reaching the (potentially expensive) authenticator.
             RateLimiter.Result rlResult = null;
             if (rateLimit != null) {
                 rlResult = rateLimit.check(request, path, clientIp);
@@ -318,8 +310,6 @@ public final class HttpRequestHandler extends SimpleChannelInboundHandler<FullHt
                 }
             }
 
-            // Authentication layer: attaches the principal on success, or short-circuits with a
-            // rejection response (401/500) for protected paths.
             if (authGate != null) {
                 Response rejection = authGate.authenticate(request, path);
                 if (rejection != null) {
@@ -360,8 +350,6 @@ public final class HttpRequestHandler extends SimpleChannelInboundHandler<FullHt
             if (cors != null) cors.applyHeaders(origin, res);
             send(ctx, res, keepAlive);
         } catch (Throwable t) {
-            // Last-resort guard: anything escaping the stages above must still produce a response,
-            // otherwise the connection would hang with auto-read disabled. Close it to be safe.
             LOG.log(Level.ERROR, "Unexpected failure while handling request", t);
             try {
                 send(ctx, new Response().status(500).json("{\"error\":\"Internal Server Error\"}"), false);
diff --git a/src/main/java/dev/coph/nextusweb/server/HttpServer.java b/src/main/java/dev/coph/nextusweb/server/HttpServer.java
index 22c2ac8..b1b25b7 100644
--- a/src/main/java/dev/coph/nextusweb/server/HttpServer.java
+++ b/src/main/java/dev/coph/nextusweb/server/HttpServer.java
@@ -237,7 +237,6 @@ public final class HttpServer {
             channelClass = NioServerSocketChannel.class;
         }
 
-        // Capture configuration into effectively-final locals for the channel initializer.
         final TlsConfig tlsCfg = this.tls;
         final CorsHandler corsHandler = this.cors;
         final RateLimitGate rateLimitGate = this.gate;
@@ -248,8 +247,7 @@ public final class HttpServer {
         final boolean tlsEnabled = tlsCfg != null;
         final TrustedProxies proxies = this.trustedProxies;
         final int maxContent = this.maxHttpContentLength;
-        final long readTimeoutSeconds = (httpReadTimeout != null && !httpReadTimeout.isZero()
-                && !httpReadTimeout.isNegative()) ? Math.max(1, httpReadTimeout.toSeconds()) : 0;
+        final long readTimeoutSeconds = (httpReadTimeout != null && !httpReadTimeout.isZero() && !httpReadTimeout.isNegative()) ? Math.max(1, httpReadTimeout.toSeconds()) : 0;
 
         try {
             new ServerBootstrap()
diff --git a/src/main/java/dev/coph/nextusweb/server/net/ClientIp.java b/src/main/java/dev/coph/nextusweb/server/net/ClientIp.java
index 17d3bea..2ca6999 100644
--- a/src/main/java/dev/coph/nextusweb/server/net/ClientIp.java
+++ b/src/main/java/dev/coph/nextusweb/server/net/ClientIp.java
@@ -31,8 +31,7 @@ public final class ClientIp {
      * @return the resolved client IP
      */
     public static String resolve(String socketIp, String forwardedForHeader, TrustedProxies trusted) {
-        if (forwardedForHeader == null || forwardedForHeader.isBlank()
-                || !trusted.isTrusted(socketIp)) {
+        if (forwardedForHeader == null || forwardedForHeader.isBlank() || !trusted.isTrusted(socketIp)) {
             return socketIp;
         }
 
@@ -45,8 +44,6 @@ public final class ClientIp {
             }
         }
 
-        // Every hop in the chain is a trusted proxy; fall back to the originating (left-most)
-        // entry, or the socket address if the header was effectively empty.
         String first = hops[0].trim();
         return first.isEmpty() ? socketIp : first;
     }
diff --git a/src/main/java/dev/coph/nextusweb/server/net/TrustedProxies.java b/src/main/java/dev/coph/nextusweb/server/net/TrustedProxies.java
index 25bb16c..0ca6ef8 100644
--- a/src/main/java/dev/coph/nextusweb/server/net/TrustedProxies.java
+++ b/src/main/java/dev/coph/nextusweb/server/net/TrustedProxies.java
@@ -129,7 +129,7 @@ public final class TrustedProxies {
         }
 
         boolean contains(byte[] addr) {
-            if (addr.length != base.length) return false; // different address family
+            if (addr.length != base.length) return false;
             int fullBytes = prefixBits / 8;
             for (int i = 0; i < fullBytes; i++) {
                 if (addr[i] != base[i]) return false;
@@ -137,13 +137,11 @@ public final class TrustedProxies {
             int remainingBits = prefixBits % 8;
             if (remainingBits != 0) {
                 int mask = 0xFF << (8 - remainingBits) & 0xFF;
-                if ((addr[fullBytes] & mask) != (base[fullBytes] & mask)) return false;
+                return (addr[fullBytes] & mask) == (base[fullBytes] & mask);
             }
             return true;
         }
 
-        // Records with array components get identity-based equals/hashCode by default; provide
-        // value semantics so deduplication and tests behave intuitively.
         @Override
         public boolean equals(Object o) {
             return o instanceof Cidr c && prefixBits == c.prefixBits && Arrays.equals(base, c.base);
diff --git a/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitConfig.java b/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitConfig.java
index 696e272..ef37bdb 100644
--- a/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitConfig.java
+++ b/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitConfig.java
@@ -46,9 +46,6 @@ public final class RateLimitConfig {
                 .sorted((a, c) -> Integer.compare(c.prefix.length(), a.prefix.length()))
                 .toList();
 
-        // Collect the distinct limiter instances once so the gate's periodic cleanup can iterate
-        // them. Identity-based de-duplication keeps a limiter shared across several rules from
-        // being cleaned multiple times per pass.
         Set<RateLimiter> limiters = Collections.newSetFromMap(new IdentityHashMap<>());
         if (globalRule != null) limiters.add(globalRule.limiter());
         for (Rule r : exactPathRules.values()) limiters.add(r.limiter());
diff --git a/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitGate.java b/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitGate.java
index 2f61b80..1bf2cdf 100644
--- a/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitGate.java
+++ b/src/main/java/dev/coph/nextusweb/server/ratelimit/RateLimitGate.java
@@ -126,7 +126,6 @@ public final class RateLimitGate {
             try {
                 limiter.cleanup(staleAfterNanos);
             } catch (RuntimeException ignored) {
-                // Best-effort eviction; never let one limiter break the cleanup cycle.
             }
         }
     }
diff --git a/src/main/java/dev/coph/nextusweb/server/router/Router.java b/src/main/java/dev/coph/nextusweb/server/router/Router.java
index be6e88a..2b7c100 100644
--- a/src/main/java/dev/coph/nextusweb/server/router/Router.java
+++ b/src/main/java/dev/coph/nextusweb/server/router/Router.java
@@ -159,8 +159,6 @@ public final class Router {
      * @return the resolution outcome, never {@code null}
      */
     public Resolution resolve(HttpMethod method, String path) {
-        // Most routes capture no path parameters; defer allocating the map until the first
-        // segment is actually captured so the common no-param case stays allocation-free.
         Map<String, String> params = null;
         Node node = root;
         for (String segment : split(path)) {
diff --git a/src/main/java/dev/coph/nextusweb/server/tls/TlsConfig.java b/src/main/java/dev/coph/nextusweb/server/tls/TlsConfig.java
index 62c5fff..1a3145b 100644
--- a/src/main/java/dev/coph/nextusweb/server/tls/TlsConfig.java
+++ b/src/main/java/dev/coph/nextusweb/server/tls/TlsConfig.java
@@ -66,8 +66,6 @@ public final class TlsConfig {
         try {
             return new TlsConfig(SslContextBuilder.forServer(certificateChain, privateKey, keyPassword).build());
         } catch (SSLException | RuntimeException e) {
-            // Netty surfaces missing/invalid PEM material as IllegalArgumentException; normalise
-            // every initialisation failure to a single, predictable exception type.
             throw new IllegalStateException("Failed to initialise TLS from PEM files", e);
         }
     }
diff --git a/src/main/java/dev/coph/nextusweb/server/websocket/WebSocketGroup.java b/src/main/java/dev/coph/nextusweb/server/websocket/WebSocketGroup.java
index 0a287a3..7a0ed6e 100644
--- a/src/main/java/dev/coph/nextusweb/server/websocket/WebSocketGroup.java
+++ b/src/main/java/dev/coph/nextusweb/server/websocket/WebSocketGroup.java
@@ -103,8 +103,6 @@ public final class WebSocketGroup {
     public WebSocketGroup broadcastJson(Object value) {
         try {
             byte[] bytes = JsonMapper.MAPPER.writeValueAsBytes(value);
-            // Build the text frame straight from the serialized UTF-8 bytes; the channel group
-            // duplicates the payload per recipient, so no String round-trip re-encode is needed.
             channels.writeAndFlush(new TextWebSocketFrame(Unpooled.wrappedBuffer(bytes)));
         } catch (JacksonException e) {
             throw new RuntimeException("JSON serialization failed", e);